Skip to content

Moiseev dmitry#69

Open
moisdima wants to merge 32 commits into
mainfrom
Moiseev_Dmitry
Open

Moiseev dmitry#69
moisdima wants to merge 32 commits into
mainfrom
Moiseev_Dmitry

Conversation

@moisdima

Copy link
Copy Markdown
Collaborator

No description provided.

@IlyaOrlov IlyaOrlov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо. Но есть замечания.

Comment thread Practice/MoiseevD/lesson_4_3.py Outdated
Comment thread Practice/MoiseevD/lesson_4_4.py Outdated
Comment thread Practice/MoiseevD/lesson_4_7.py
Comment thread Practice/MoiseevD/lesson_4_8.py Outdated
Comment thread Practice/MoiseevD/lesson_4_8.py Outdated
Comment thread Practice/MoiseevD/lesson_4_8.py Outdated
Comment thread Practice/MoiseevD/lesson_5_1.py Outdated

@IlyaOrlov IlyaOrlov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ОК. Осталось одно существенное замечание!

@IlyaOrlov IlyaOrlov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оставил мелкие замечания.

Comment thread Practice/MoiseevD/lesson_6_1.py Outdated
Comment thread Practice/MoiseevD/lesson_6_2.py Outdated


def __add__(self, other):
return self._weight + other._weight

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отступов многовато.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправил

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет. И в других методах стало так же (8 пробелов, а должно быть 4). Возможно, проблема с табуляцией.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправил

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет. Ничего не исправилось (см. вкладку Files changed - https://github.com/IlyaOrlov/PythonCourse2.0_August22/pull/69/files)

Comment thread Practice/MoiseevD/lesson_6_2.py Outdated

@IlyaOrlov IlyaOrlov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо, но вопросы ещё остались.



def __add__(self, other):
return self._weight + other._weight

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет. И в других методах стало так же (8 пробелов, а должно быть 4). Возможно, проблема с табуляцией.

@IlyaOrlov IlyaOrlov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вопрос по банкоматам. И отступы всё же надо поправить.

lst2 = Bankomat2(1500)
lst3 = Bankomat3(3000)

lst1.input_output()

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А как узнать, какие операции поддерживает тот или иной банкомат?

@IlyaOrlov IlyaOrlov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С таймером всё ОК. Старые замечания остались.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants